0
  9   +ˆl–ßi~”J_)�?q°©‹FÿÎƒDa–ßi~”ªi?u8 �q ÜTÅ£Í I    +Reviewing and merging patches
=============================

Everyone is encouraged to review open pull requests. We only ask that you try
and think carefully, ask questions and are `excellent to one another`_. Code
review is our opportunity to share knowledge, design ideas and make friends.

When reviewing a patch try to keep each of these concepts in mind:

Intent
------

* What is the change being proposed?
* Do we want this feature or is the bug they're fixing really a bug?

Architecture
------------

* Is the proposed change being made in the correct place? Is it a fix in the
  backend when it should be in the primitives?

Implementation
--------------

* Does the change do what the author claims?
* Are there sufficient tests?
* Has it been documented?
* Will this change introduce new bugs?

Grammar and style
-----------------

These are small things that are not caught by the automated style checkers.

* Does a variable need a better name?
* Should this be a keyword argument?

Merge requirements
------------------

Because cryptography is so complex, and the implications of getting it wrong so
devastating, ``cryptography`` has a strict merge policy for committers:

* Patches must *never* be pushed directly to ``main``, all changes (even the
  most trivial typo fixes!) must be submitted as a pull request.
* A committer may *never* merge their own pull request, a second party must
  merge their changes. If multiple people work on a pull request, it must be
  merged by someone who did not work on it.
* A patch that breaks tests, or introduces regressions by changing or removing
  existing tests should not be merged. Tests must always be passing on
  ``main``.
* If somehow the tests get into a failing state on ``main`` (such as by a
  backwards incompatible release of a dependency) no pull requests may be
  merged until this is rectified.
* All merged patches must have 100% test coverage.

The purpose of these policies is to minimize the chances we merge a change
that jeopardizes our users' security.

.. _`excellent to one another`: https://speakerdeck.com/ohrite/better-code-review
  #   /ˆl–ßi~”jn-jq@»q·®21hßÐ„d,ºÿ¿Î ?÷     /a
    F‡©j÷³  ã                   @   sÔ   d dl Z d dlZ d dlmZ d dlmZmZmZ d dlm	Z	 d dl
mZ d dlmZ d dlmZ d dlmZ d d	lmZ d d
lmZmZmZmZ d dlmZ d dlmZ d dlmZmZmZm Z  G dd„ deƒZ!dS )é    N)Úconfig)Údbus_to_pythonÚ%dbus_introspection_prepare_propertiesÚ!dbus_introspection_add_properties)ÚZone)Úifcfg_set_zone_of_interface)ÚDEFAULT_ZONE_TARGET)Ú	Rich_Rule)Úlog)ÚDbusServiceObject)Úhandle_exceptionsÚdbus_handle_exceptionsÚdbus_service_methodÚdbus_polkit_require_auth)Úerrors)ÚFirewallError)ÚportStrÚportInPortRangeÚcoalescePortRangeÚbreakPortRangec                       sœ	  e Zd ZdZdZejjZe	‡ fdd„ƒZ
edd„ ƒZedd„ ƒZed	d
„ ƒZeejddd�edºdd„ƒƒZeejddd�ed»dd„ƒƒZeejjƒeejdd�ed¼dd„ƒƒƒZejjejdd�dd„ ƒZeejjƒeejdd�ed½‡ fdd„	ƒƒƒZeejjd d�ed¾d!d"„ƒƒZeejjdd�ed¿d#d$„ƒƒZd%d&„ Zeejjd d�edÀd'd(„ƒƒZeejjdd�edÁd)d*„ƒƒZ eejjƒedÂd+d,„ƒƒZ!ejjejjdd�ed-d.„ ƒƒZ"eejjƒedÃd/d0„ƒƒZ#ejjejjdd�ed1d2„ ƒƒZ$eejjdd�edÄd3d4„ƒƒZ%ejjejjdd�ed5d6„ ƒƒZ&eejjdd�edÅd7d8„ƒƒZ'eejjdd�edÆd9d:„ƒƒZ(eejjdd�edÇd;d<„ƒƒZ)eejjdd�edÈd=d>„ƒƒZ*eejjdd�edÉd?d@„ƒƒZ+eejjdd�edÊdAdB„ƒƒZ,eejjdd�edËdCdD„ƒƒZ-eejjdd�edÌdEdF„ƒƒZ.eejjdGd�edÍdHdI„ƒƒZ/eejjdGd�edÎdJdK„ƒƒZ0eejjdd�edÏdLdM„ƒƒZ1eejjdd�edÐdNdO„ƒƒZ2eejjddPd�edÑdQdR„ƒƒZ3eejjdSd�edÒdTdU„ƒƒZ4eejjdSd�edÓdVdW„ƒƒZ5eejjdd�edÔdXdY„ƒƒZ6eejjdd�edÕdZd[„ƒƒZ7eejjddPd�edÖd\d]„ƒƒZ8eejjdGd�ed×d^d_„ƒƒZ9eejjdGd�edØd`da„ƒƒZ:eej